setSecret is not working as expected

[itsrafsanjani]

I'm trying to set the jwt secret dynamically for my multitenancy based app like this: check the link

But I'm getting errors.

{
    "message": "An error occurred",
    "exception": "PHPOpenSourceSaver\\JWTAuth\\Exceptions\\SecretMissingException",
    "file": "D:\\laragon\\www\\acculance-saas\\vendor\\php-open-source-saver\\jwt-auth\\src\\Providers\\JWT\\Provider.php",
    "line": 47,
    "trace": [
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\php-open-source-saver\\jwt-auth\\src\\Providers\\JWT\\Lcobucci.php",
            "line": 79,
            "function": "__construct",
            "class": "PHPOpenSourceSaver\\JWTAuth\\Providers\\JWT\\Provider",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\php-open-source-saver\\jwt-auth\\src\\Providers\\AbstractServiceProvider.php",
            "line": 169,
            "function": "__construct",
            "class": "PHPOpenSourceSaver\\JWTAuth\\Providers\\JWT\\Lcobucci",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 871,
            "function": "PHPOpenSourceSaver\\JWTAuth\\Providers\\{closure}",
            "class": "PHPOpenSourceSaver\\JWTAuth\\Providers\\AbstractServiceProvider",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 756,
            "function": "build",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php",
            "line": 855,
            "function": "resolve",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 692,
            "function": "resolve",
            "class": "Illuminate\\Foundation\\Application",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php",
            "line": 840,
            "function": "make",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\php-open-source-saver\\jwt-auth\\src\\Providers\\AbstractServiceProvider.php",
            "line": 355,
            "function": "make",
            "class": "Illuminate\\Foundation\\Application",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\php-open-source-saver\\jwt-auth\\src\\Providers\\AbstractServiceProvider.php",
            "line": 141,
            "function": "getConfigInstance",
            "class": "PHPOpenSourceSaver\\JWTAuth\\Providers\\AbstractServiceProvider",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 871,
            "function": "PHPOpenSourceSaver\\JWTAuth\\Providers\\{closure}",
            "class": "PHPOpenSourceSaver\\JWTAuth\\Providers\\AbstractServiceProvider",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 756,
            "function": "build",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php",
            "line": 855,
            "function": "resolve",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 692,
            "function": "resolve",
            "class": "Illuminate\\Foundation\\Application",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php",
            "line": 840,
            "function": "make",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 1415,
            "function": "make",
            "class": "Illuminate\\Foundation\\Application",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\php-open-source-saver\\jwt-auth\\src\\Providers\\AbstractServiceProvider.php",
            "line": 202,
            "function": "offsetGet",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 871,
            "function": "PHPOpenSourceSaver\\JWTAuth\\Providers\\{closure}",
            "class": "PHPOpenSourceSaver\\JWTAuth\\Providers\\AbstractServiceProvider",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 756,
            "function": "build",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php",
            "line": 855,
            "function": "resolve",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 692,
            "function": "resolve",
            "class": "Illuminate\\Foundation\\Application",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php",
            "line": 840,
            "function": "make",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 1415,
            "function": "make",
            "class": "Illuminate\\Foundation\\Application",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\php-open-source-saver\\jwt-auth\\src\\Providers\\AbstractServiceProvider.php",
            "line": 244,
            "function": "offsetGet",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 871,
            "function": "PHPOpenSourceSaver\\JWTAuth\\Providers\\{closure}",
            "class": "PHPOpenSourceSaver\\JWTAuth\\Providers\\AbstractServiceProvider",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 756,
            "function": "build",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php",
            "line": 855,
            "function": "resolve",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 692,
            "function": "resolve",
            "class": "Illuminate\\Foundation\\Application",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php",
            "line": 840,
            "function": "make",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php",
            "line": 1415,
            "function": "make",
            "class": "Illuminate\\Foundation\\Application",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\php-open-source-saver\\jwt-auth\\src\\Providers\\AbstractServiceProvider.php",
            "line": 99,
            "function": "offsetGet",
            "class": "Illuminate\\Container\\Container",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Auth\\AuthManager.php",
            "line": 111,
            "function": "PHPOpenSourceSaver\\JWTAuth\\Providers\\{closure}",
            "class": "PHPOpenSourceSaver\\JWTAuth\\Providers\\AbstractServiceProvider",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Auth\\AuthManager.php",
            "line": 88,
            "function": "callCustomCreator",
            "class": "Illuminate\\Auth\\AuthManager",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Auth\\AuthManager.php",
            "line": 68,
            "function": "resolve",
            "class": "Illuminate\\Auth\\AuthManager",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Support\\Facades\\Facade.php",
            "line": 337,
            "function": "guard",
            "class": "Illuminate\\Auth\\AuthManager",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\app\\Http\\Middleware\\RedirectIfAuthenticated.php",
            "line": 25,
            "function": "__callStatic",
            "class": "Illuminate\\Support\\Facades\\Facade",
            "type": "::"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "App\\Http\\Middleware\\RedirectIfAuthenticated",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 116,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Routing\\Router.php",
            "line": 726,
            "function": "then",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Routing\\Router.php",
            "line": 703,
            "function": "runRouteWithinStack",
            "class": "Illuminate\\Routing\\Router",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Routing\\Router.php",
            "line": 667,
            "function": "runRoute",
            "class": "Illuminate\\Routing\\Router",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Routing\\Router.php",
            "line": 656,
            "function": "dispatchToRoute",
            "class": "Illuminate\\Routing\\Router",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Http\\Kernel.php",
            "line": 167,
            "function": "dispatch",
            "class": "Illuminate\\Routing\\Router",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 141,
            "function": "Illuminate\\Foundation\\Http\\{closure}",
            "class": "Illuminate\\Foundation\\Http\\Kernel",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\barryvdh\\laravel-debugbar\\src\\Middleware\\InjectDebugbar.php",
            "line": 67,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "Barryvdh\\Debugbar\\Middleware\\InjectDebugbar",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\app\\Http\\Middleware\\SetLocale.php",
            "line": 22,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "App\\Http\\Middleware\\SetLocale",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest.php",
            "line": 21,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Http\\Middleware\\ConvertEmptyStringsToNull.php",
            "line": 31,
            "function": "handle",
            "class": "Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "Illuminate\\Foundation\\Http\\Middleware\\ConvertEmptyStringsToNull",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest.php",
            "line": 21,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Http\\Middleware\\TrimStrings.php",
            "line": 40,
            "function": "handle",
            "class": "Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "Illuminate\\Foundation\\Http\\Middleware\\TrimStrings",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Http\\Middleware\\ValidatePostSize.php",
            "line": 27,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "Illuminate\\Foundation\\Http\\Middleware\\ValidatePostSize",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Http\\Middleware\\PreventRequestsDuringMaintenance.php",
            "line": 86,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "Illuminate\\Foundation\\Http\\Middleware\\PreventRequestsDuringMaintenance",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Http\\Middleware\\HandleCors.php",
            "line": 62,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "Illuminate\\Http\\Middleware\\HandleCors",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Http\\Middleware\\TrustProxies.php",
            "line": 39,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "Illuminate\\Http\\Middleware\\TrustProxies",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Http\\Middleware\\TrustHosts.php",
            "line": 48,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 180,
            "function": "handle",
            "class": "Illuminate\\Http\\Middleware\\TrustHosts",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php",
            "line": 116,
            "function": "Illuminate\\Pipeline\\{closure}",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Http\\Kernel.php",
            "line": 142,
            "function": "then",
            "class": "Illuminate\\Pipeline\\Pipeline",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Http\\Kernel.php",
            "line": 111,
            "function": "sendRequestThroughRouter",
            "class": "Illuminate\\Foundation\\Http\\Kernel",
            "type": "->"
        },
        {
            "file": "D:\\laragon\\www\\acculance-saas\\public\\index.php",
            "line": 52,
            "function": "handle",
            "class": "Illuminate\\Foundation\\Http\\Kernel",
            "type": "->"
        }
    ]
}```

[Messhias]

If not wrong SecretMissingException is something related to your jwt secret on your .env, did you generate your secret on .env?

[itsrafsanjani]

I just wanted to use the secret dynamically
JWTAuth::getJWTProvider()->setSecret('foobarbaz')
like this. So I don't want to use the secret from the .env

[mfn]

Bummer. That's currently not supported. By virtue of fixing #116 via #123 we effectively don't support starting up with no secret and then changing it.

Untested workaround: define some secret. And then change it 🤷🏼

The idea was to prevent errors of forgetting them in the first place.

Also from #116 (comment)

But it needs to be checked if it has some side effects.

😬

---

Not sure how the other devs feel about this, we might consider just reverting #123 : I guess the basic idea was to "just provide a nicer message" (?), but in the end, technically, nothing was broken: it just bombed at a later point if ppl forgot to set a secret but OTOH it breaks your use case with dynamic secrets (and I don't see a reason not to support this).

@Messhias @eschricker WDYT?

[itsrafsanjani]

Untested workaround: define some secret. And then change it 🤷🏼

I tried that at first and then created the issue! It was always trying to read from .env.

[eschricker]

Bummer. That's currently not supported. By virtue of fixing #116 via #123 we effectively don't support starting up with no secret and then changing it.

Untested workaround: define some secret. And then change it 🤷🏼

The idea was to prevent errors of forgetting them in the first place.

Also from #116 (comment)

But it needs to be checked if it has some side effects.

grimacing

Not sure how the other devs feel about this, we might consider just reverting #123 : I guess the basic idea was to "just provide a nicer message" (?), but in the end, technically, nothing was broken: it just bombed at a later point if ppl forgot to set a secret but OTOH it breaks your use case with dynamic secrets (and I don't see a reason not to support this).

@Messhias @eschricker WDYT?

I think the message is very helpful. I would suggest to introduce a new config parameter like JWT_DYNAMIC_SECRET which defaults to false. When this is set to true, the check for the secrets will be skipped. What do you think about this instead of reverting @mfn?

[mfn]

TBH this feels like bolting on thing onto another.

My vote is on reverting. The intention is good and was thought nice, but effectively due to lack of tests we broke valid use cases. Introduced yet another option to make something work, which worked before, doesn't feel right to me.