Are we actually using code coverage?

[mfn]

Reason for asking is that I discovered this warning by accident: https://github.com/PHP-Open-Source-Saver/jwt-auth/actions/runs/1504327723

[PHP 8] [Laravel 8.* - prefer-stable] [xdebug coverage]
Unexpected input(s) 'yml', valid inputs are ['token', 'files', 'directory', 'flags', 'aws_curl_args', 'codecov_curl_args', 'commit_parent', 'env_vars', 'fail_ci_if_error', 'file', 'functionalities', 'gcov_args', 'gcov_executable', 'gcov_path_exclude', 'gcov_path_include', 'gcov_prefix', 'gcov_root_dir', 'move_coverage_to_trash', 'name', 'network_filter', 'override_branch', 'override_build', 'override_commit', 'override_pr', 'override_tag', 'path_to_write_report', 'root_dir', 'verbose', 'working-directory', 'xcode_derived_data', 'xcode_package']

I don't quite understand this warning, they seem for v2 but we reference v1; maybe a github action limitation.

I checked the link https://codecov.io/github/PHP-Open-Source-Saver/jwt-auth/commit/5823ab9c8bee3e6d4860f9e3cf3b9fa7d1e30889 and it seems to work.

Still asking if anyone is checking this? I know it can be set up to add a comment using fancy graphs. But I also know many projects removing them because they're annoying.

My approach is rather:

• if you add something in a PR, add tests for it
• if you change something and no test broke/needed fixing, please add a test

WDYT?

[Messhias]

Reason for asking is that I discovered this warning by accident: https://github.com/PHP-Open-Source-Saver/jwt-auth/actions/runs/1504327723

[PHP 8] [Laravel 8.* - prefer-stable] [xdebug coverage]
Unexpected input(s) 'yml', valid inputs are ['token', 'files', 'directory', 'flags', 'aws_curl_args', 'codecov_curl_args', 'commit_parent', 'env_vars', 'fail_ci_if_error', 'file', 'functionalities', 'gcov_args', 'gcov_executable', 'gcov_path_exclude', 'gcov_path_include', 'gcov_prefix', 'gcov_root_dir', 'move_coverage_to_trash', 'name', 'network_filter', 'override_branch', 'override_build', 'override_commit', 'override_pr', 'override_tag', 'path_to_write_report', 'root_dir', 'verbose', 'working-directory', 'xcode_derived_data', 'xcode_package']

I don't quite understand this warning, they seem for v2 but we reference v1; maybe a GitHub action limitation.

I checked the link https://codecov.io/github/PHP-Open-Source-Saver/jwt-auth/commit/5823ab9c8bee3e6d4860f9e3cf3b9fa7d1e30889 and it seems to work.

Still asking if anyone is checking this? I know it can be set up to add a comment using fancy graphs. But I also know many projects removing them because they're annoying.

My approach is rather:

• if you add something in a PR, add tests for it
• if you change something and no test broke/needed fixing, please add a test

WDYT?

This warning it's a code coverage of the debug version with actual laravel coverage of new conventions.

My PHP artisan serve makes my debug give some warnings too.

[leon0399]

I think we can add enable comments, but somehow make it less annoying by adding rules to GitHub Actions to run only when sources changed (only on PRs with changes in src/, tests/ folder)

[mfn]

only on PRs with changes in src/, tests/ folder

That sounds actually good!

And we probably should upgrade the action to v2 while we're at it.

[Messhias]

only on PRs with changes in src/, tests/ folder

That sounds actually good!

And we probably should upgrade the action to v2 while we're at it.

Yes is good, on my side what I don't just turn it off, since I'm using PHPStorm IDE it has already helped me out to keep the projector in PRS's standards.