Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping Years During Stage 2 #386

Open
andersonfrailey opened this issue May 23, 2021 · 1 comment
Open

Skipping Years During Stage 2 #386

andersonfrailey opened this issue May 23, 2021 · 1 comment
Labels
enhancement extrapolation Issues/PRs related to our extrapolation techniques

Comments

@andersonfrailey
Copy link
Collaborator

As mentioned in #381 and other issues, running our stage 2 scripts takes forever. Beyond changing solvers, another change I want to make to speed this process up is to only run the LP model for years that have seen their targets change. For example, in the PUF the targets for 2012 to 2017 have not and will not change because the CBO won't be releasing any new data and we won't be changing out SOI estimates. This means the final weights also will not change and solving for them is really just a waste of time and resources.

I'd like to propose simply skipping these years by adding a check to the stage 2 scripts that compares the targets checked into this repo for a given year to those on the local machine of whoever is running the scripts and skipping the solver for that year if they're the same. I also want to add a file to the repo that contains the MD5 check-sum for cps-matched-puf.csv and cps.csv.gz. These will be compared to the local files as well so that if there is a change to either we'll create new weights for all years. For the years that are skipped, we'll just use the weights that have already been created.

A minor downside to this is it would kind of lock us into a solver because the checks wouldn't been looking to see if we're using a new solver. We can overcome this by adding an option to force the model to solve for all years.

I believe these checks should prevent skipping years that we actually need, but if anyone can think of additional checks I should impose please let me know.

cc @donboyd5 @MattHJensen

@donboyd5
Copy link

@andersonfrailey, I really like this idea.

@andersonfrailey andersonfrailey added enhancement extrapolation Issues/PRs related to our extrapolation techniques labels May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement extrapolation Issues/PRs related to our extrapolation techniques
Projects
None yet
Development

No branches or pull requests

2 participants