Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Some attributes are incorrectly hyphenized when using toString #8

Open
francis-de-ladu opened this issue Sep 1, 2021 · 2 comments
Open

Some attributes are incorrectly hyphenized when using toString #8

francis-de-ladu opened this issue Sep 1, 2021 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@francis-de-ladu
Copy link

francis-de-ladu commented Sep 1, 2021 •
edited
Loading

Add an issue with attempting to convert some SVGs to string using Svg.String.toString.

The viewBox attribute is incorrectly converted to the view-box string when using toString, which simply makes the attribute ignored by browsers.

Had to pipe the output into String.replace "view-box" "viewBox" to fix the issue.
@PedroHLC
Copy link
Contributor

Hi @francis-de-ladu, can you send a PR for fixing this?
We're full of other tasks until Black Friday 😅

@PedroHLC PedroHLC added bug Something isn't working help wanted Extra attention is needed labels Sep 17, 2021
@johannesvollmer
Copy link

johannesvollmer commented Oct 21, 2022 •
edited
Loading

hi, i have prepared a proposal in pr #10

johannesvollmer added a commit to johannesvollmer/elm-svg-string that referenced this issue Oct 21, 2022
@johannesvollmer
add more types
9d545fe 
closes PaackEng#8
closes PaackEng#6
closes PaackEng#5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PedroHLC @francis-de-ladu @johannesvollmer