Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PNG screenshots #139

Closed
10 tasks done
kai-li-wop opened this issue Mar 22, 2022 · 4 comments
Closed
10 tasks done

Support for PNG screenshots #139

kai-li-wop opened this issue Mar 22, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kai-li-wop
Copy link
Member

kai-li-wop commented Mar 22, 2022

It would be nice to have support for PNG screenshots available in WoP e.g. to create some high quality screenshots for presentation purposes directly in PNG format. There is a PR for ioquake3 by @zturtleman already taking care about a feature like that. I think it also contains a few fixes regarding JPEG support.
I also like the idea about giving the user control via the game menu in what format he/she wants to save a screenshot. We should offer here a drop down option to select the desired screenshot format (PNG, JPG, TGA). Simply to find a space for that.

Task to perform

  • Evaluate the PR code for compatibility
  • Check for necessity of meta data as stated by @robo9k
  • Apply the PR code
  • Adopt the PR code to work with VULKAN renderer --> @mgerhardy
  • Add option to select screenshot format PNG, JPG or TGA to Setup menu
  • (?)Then 'screenshot' command and format must be separate values
  • (?)Set the screenshot format via new CVAR 'r_screenshotFormat' 0=TGA; 1=JPG; 2=PNG
  • (?)Set 2=PNG the new default
  • (?)Bind a key to 'screenshot' only and format is decided by 'r_screenshotFormat' then
  • Add a key binding option to Controls menu Misc page
@kai-li-wop kai-li-wop added the enhancement New feature or request label Mar 22, 2022
@kai-li-wop kai-li-wop added this to the v1.7.0 milestone Mar 22, 2022
@kai-li-wop kai-li-wop moved this to Backlog in WoP 1.7.x Mar 22, 2022
@kai-li-wop kai-li-wop moved this from Backlog to In Progress in WoP 1.7.x Mar 22, 2022
@kai-li-wop
Copy link
Member Author

kai-li-wop commented Jan 17, 2023

@mgerhardy: I could use your help here. I would like to finalize this feature and to merge it into main. ;)

  1. I cannot manage to include zlib.h header file in rendercommon/tr_public.h in a correct way. Do I need to add something to a makelist? Also I cannot adopt the PR code to work with the VULKAN renderer. I would be very glad if you could have a look and try to implement it in the same way like with the other renderers.
  2. I need some opinion if my approach described in the bullets list marked with (?) is a suitable one.

@mgerhardy
Copy link
Member

vulkan is done

about the screenshot type cvar - i have no strong opinion about it. as it's currently implemented in the three renderers, it's just about three lines of code - not much duplication. But it would most likely be easier for the user to make this a cvar and put into the menu. I would do this (if at all) in a separate PR.

@kai-li-wop kai-li-wop changed the title Support for PNG screenshots and selection via menu Support for PNG screenshots Jan 23, 2023
@kai-li-wop kai-li-wop moved this from In Progress to Ready for Review in WoP 1.7.x Jan 23, 2023
@kai-li-wop
Copy link
Member Author

kai-li-wop commented Jan 23, 2023

The integration of screenshot format selection in the menu will be handled in an extra ticket #183.
To test the new screenshot feature use the following commands

  • TGA: screenshot
  • JPEG: screenshotJPEG
  • PNG: screenshot PNG (new)

Would be good to test this with all available renderers. On Windows switching to vulkan will cause probably a crash since it is not officially supported yet.

@kai-li-wop
Copy link
Member Author

Due to #184 you cannot test the feature via the 3 screenshot commands since only screenshot is the leftover command. Use the menu option in Setup/Display to chose the desired screenshot format.

@github-project-automation github-project-automation bot moved this from Ready for Review to Done in WoP 1.7.x Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants