-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PNG screenshots #139
Comments
@mgerhardy: I could use your help here. I would like to finalize this feature and to merge it into main. ;)
|
vulkan is done about the screenshot type cvar - i have no strong opinion about it. as it's currently implemented in the three renderers, it's just about three lines of code - not much duplication. But it would most likely be easier for the user to make this a cvar and put into the menu. I would do this (if at all) in a separate PR. |
The integration of screenshot format selection in the menu will be handled in an extra ticket #183.
Would be good to test this with all available renderers. On Windows switching to vulkan will cause probably a crash since it is not officially supported yet. |
Due to #184 you cannot test the feature via the 3 screenshot commands since only |
It would be nice to have support for PNG screenshots available in WoP e.g. to create some high quality screenshots for presentation purposes directly in PNG format. There is a PR for ioquake3 by @zturtleman already taking care about a feature like that. I think it also contains a few fixes regarding JPEG support.
I also like the idea about giving the user control via the game menu in what format he/she wants to save a screenshot. We should offer here a drop down option to select the desired screenshot format (PNG, JPG, TGA). Simply to find a space for that.Task to perform
Add option to select screenshot format PNG, JPG or TGA to Setup menu(?)Then 'screenshot' command and format must be separate values(?)Set the screenshot format via new CVAR 'r_screenshotFormat' 0=TGA; 1=JPG; 2=PNG(?)Set 2=PNG the new default(?)Bind a key to 'screenshot' only and format is decided by 'r_screenshotFormat' thenThe text was updated successfully, but these errors were encountered: