Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: support instrumentation #26

Open
groob opened this issue Dec 10, 2016 · 1 comment
Open

proposal: support instrumentation #26

groob opened this issue Dec 10, 2016 · 1 comment

Comments

@groob
Copy link

groob commented Dec 10, 2016

It would be useful if the cert manager had support for metrics.
Some useful data to keep track of:

  • number of certs issued/renewed
  • time to acquire a cert
  • number of errors

I use prometheus to monitor our k8s services, but some people use other monitoring solutions. I'd like to add metrics support to this projects, using the github.com/go-kit/kit/metrics library with initial support for prometheus and expvar endpoints.

Would you be interested in this? Any thoughts/concerns?

@luna-duclos
Copy link

As long as things keep working if there is no metrics endpoint available, yes, this would be absolutely very interesting. It could also be mixed with #13 and #12 as it'd probably touch the same code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants