Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error handling for getting all ingresses, secrets, certificates #29

Open
whereisaaron opened this issue Jan 14, 2017 · 2 comments

Comments

@whereisaaron
Copy link
Contributor

While establishing RBAC permissions for kube-cert-manager, it was running without permissions to do the things it needs. For many requests it recognized the permission problem and logged something sensible e.g:

2017/01/14 02:26:01 unexpected HTTP status code while creating event: 403

However for other bulk operations, it appears not to recognize the error, instead trying to parse the failed response. This seemed to apply to fetching lists of ingresses, secrets, and certificates. I assume it got back a 200 response that said "Found no resources" or similar, since it always seems to start with 'F'!

2017/01/14 01:52:04 Error while synchronizing certificates during refresh: Error while fetching certificate list: invalid character 'F' looking for beginning of value
2017/01/14 02:16:18 Error while synchronizing ingresses during refresh: Error while fetching ingress list: invalid character 'F' looking for beginning of value
2017/01/14 02:16:18 Error cleaning up secrets: Error while fetching secret list: invalid character 'F' looking for beginning of value

I think the way to recreate this is to allow access to all nonResourceURLs but not allow access to any resources.

@luna-duclos
Copy link

This seems a legit issue and will need a fix

@whereisaaron
Copy link
Contributor Author

Scarcely urgent though, so file it under 'one day' 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants