grouped cards still become discussion topics when using suggest groups

[drewhousman1010]

I just hopped on a call with an Enterprise customer 🔒 who noticed a bug while using suggest groups. Every single reflection became a discussion item, even though the ones that were already part of a group. See slack discussion 🔒 for screenshot

[nickoferrall]

This issue could be related: https://parabol.slack.com/archives/C4JAUUZ9P/p1738949200037559

I see this session replay where they seem to click on Suggest Groups: https://app.datadoghq.com/rum/replay/sessions/86aab36a-a000-40da-8a59-5d16abb7befd?applicationId=93eae3f6-9099-4924-9508-9559c9550dce&seed=3d729c09-93ea-4445-8d25-4c62a12acf87&ts=1738938636547

I've been looking into this today. I haven't been able to reproduce it yet, but I can see that in handleCompletedStage we synchronously generate the groups with AI.

If the OpenAI call takes a long time and the user moves past the Group stage, it looks like we unlock all of the stages for the Discuss phase:

parabol/packages/server/graphql/mutations/helpers/handleCompletedStage.ts

Line 61 in bf8fc7e

unlockAllStagesForPhase(phases, 'discuss', true)

I suspect there could be a race condition. Perhaps we need to find a way of adding the side effects to a queue, and we don't unlock all stages until generate groups is complete 🤔

Looking into this.