Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting inception: post meeting card to the discussion #8751

Closed
igorlesnenko opened this issue Aug 30, 2023 · 4 comments
Closed

Meeting inception: post meeting card to the discussion #8751

igorlesnenko opened this issue Aug 30, 2023 · 4 comments

Comments

@igorlesnenko
Copy link
Contributor

igorlesnenko commented Aug 30, 2023

image

AC:

  • Add an activity button should redirect to the activity library (in a new tab) and provide an additional param, probably discussionId
  • After the new meeting is created, it should be posted to the discussion thread (see screenshot)
  • Validate that the meeting is not ended and access control

Questions:

  • Should we support all meeting types here? cc @acressall
  • Probably we need to somehow additionally track meetings created like this in the segment. How? Store sourceMeetingId? cc @tghanken
@tghanken
Copy link
Contributor

Probably we need to somehow additionally track meetings created like this in the segment. How? Store sourceMeetingId? cc @tghanken

Yest, that makes sense to me. If we add that to the Meeting Started event, it should be enough for us to track this!

@acressall
Copy link
Contributor

Should we support all meeting types here?

Yes. If this is going to be a lot of UI work I can design a trimmed down version

@igorlesnenko
Copy link
Contributor Author

Now I'm thinking we can show activity-library in a popup window, not a new tab. Probably this way it will be more obvious that something will happen if you add an activity. And if we implement 'user is adding activity' placeholder, you will able to see it this way.
And use some existing method of communication between windows. Maybe postMessage? Need to check

@acressall
Copy link
Contributor

The concern with showing it in a modal was that we'd have to adjust the activity library from it's fullscreen form. Not the end of the world, but a bit more work. LMK if you'd like me to whip up what the design adjustments would be.

Alternatively, we could show the old meeting picker to start and do the activity library later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: No status
Development

No branches or pull requests

4 participants