You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your improvement related to a problem? Please describe.
ServicePulse has type definitions for ServiceControl API in the /src/frontend/src/resources folder. If ServiceControl API changes its DTOs schema, the corresponding type must also be updated in the ServicePulse codebase.
Describe the suggested solution
Automatically generate a ServiceControlAPI.d.ts file in the ServiceControl build and push it as an NPM package.
Make ServicePulse reference the NPM package with the ServiceControl API typescript types. This will automatically make Dependabot create a PR in the ServicePulse repo to update the NPM package whenever a new version of ServiceContrl API types is released.
Note: When this issue was created, ServicePulse had a series of types that extended the ServiceControl API types with properties used by the UI components. This has to be considered when estimating the effort needed to address the idea this issue proposes.
Describe alternatives you've considered
Do nothing and continue manually maintaining the ServiceControl API types in the ServicePulse repo.
Additional Context
No response
The text was updated successfully, but these errors were encountered:
cquirosj
changed the title
ServiceControl API Typescript types declarations as an npm package
ServiceControl API Typescript types definitions as an npm package
Jun 28, 2024
cquirosj
changed the title
ServiceControl API Typescript types definitions as an npm package
ServiceControl API Typescript type definitions as an npm package
Jun 28, 2024
cquirosj
changed the title
ServiceControl API Typescript type definitions as an npm package
Generate ServiceControl API Typescript type definitions as an npm package
Jun 28, 2024
Describe the suggested improvement
Is your improvement related to a problem? Please describe.
ServicePulse has type definitions for ServiceControl API in the
/src/frontend/src/resources folder
. If ServiceControl API changes its DTOs schema, the corresponding type must also be updated in the ServicePulse codebase.Describe the suggested solution
Automatically generate a ServiceControlAPI.d.ts file in the ServiceControl build and push it as an NPM package.
Make ServicePulse reference the NPM package with the ServiceControl API typescript types. This will automatically make Dependabot create a PR in the ServicePulse repo to update the NPM package whenever a new version of ServiceContrl API types is released.
Note: When this issue was created, ServicePulse had a series of types that extended the ServiceControl API types with properties used by the UI components. This has to be considered when estimating the effort needed to address the idea this issue proposes.
Describe alternatives you've considered
Do nothing and continue manually maintaining the ServiceControl API types in the ServicePulse repo.
Additional Context
No response
The text was updated successfully, but these errors were encountered: