Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated notification for same intersection and redundant intersection checks #432

Open
tremblerz opened this issue Apr 11, 2020 · 1 comment
Labels
Work In Progress Don't merge quite yet, still in progress

Comments

@tremblerz
Copy link
Contributor

The way we are checking for intersection is based on storing data and checking it periodically and sending a notification if an intersection is found. Now the issue here is that the intersection which happened 5 days ago will get flagged again when it is found on the next day as an intersection which happened 6 days ago.

We need to find a way to get rid of the duplicate notifications in the time domain. This, in general, also brings the point that right now we check for whole intersection every 12 hours which might not be a good idea, especially when the public json files would be larger.

@tremblerz tremblerz added help wanted Extra attention is needed High Priority High importance / High value labels Apr 11, 2020
@harshvitra
Copy link
Collaborator

One possible solution is that when we check for intersection we store the timestamp in the Local Storage

If there is no timestamp - check entire public json
If there is timestamp - we only check values higher than the timestamp

@Patrick-Erichsen Patrick-Erichsen added Work In Progress Don't merge quite yet, still in progress and removed High Priority High importance / High value help wanted Extra attention is needed labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work In Progress Don't merge quite yet, still in progress
Projects
None yet
Development

No branches or pull requests

3 participants