Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work in Windows #39

Closed
rmhrisk opened this issue Jun 12, 2016 · 2 comments
Closed

Work in Windows #39

rmhrisk opened this issue Jun 12, 2016 · 2 comments
Labels
bug

Comments

@rmhrisk
Copy link
Contributor

rmhrisk commented Jun 12, 2016

We are having an issue working in windows which is blocked by node-ffi - TooTallNate/ref-struct#22
@rmhrisk rmhrisk added the bug label Jun 12, 2016
@rmhrisk rmhrisk mentioned this issue Jul 1, 2016
Closed
@rmhrisk
Copy link
Contributor Author

rmhrisk commented Jul 3, 2016

I wonder if this issue is a x64 bit issue, ffi says: https://www.npmjs.com/package/ffi

Internally, V8 stores integers that will fit into a 32-bit space in a 32-bit integer, and those that fall outside of this get put into double-precision floating point numbers. This is problematic because FP numbers are imprecise. To get around this, the methods in node-ffi that deal with 64-bit integers return strings and can accept strings as parameters.

Maybe ref-struct doesn't deal with the floating point numbers effectively?

@rmhrisk
Copy link
Contributor Author

rmhrisk commented Aug 15, 2016

Graphene 2.x works in Windows

@rmhrisk rmhrisk closed this as completed Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmhrisk