v0.103010 install fails on 5.14.2

[dnmfarrell]

Looks like the same issue is showing on CPANTESTERS

This is on Ubuntu x86_64:

Distributor ID: Ubuntu
Description:    Ubuntu 12.04.5 LTS
Release:        12.04
Codename:       precise

Test report:

Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Software::License
Writing MYMETA.yml and MYMETA.json
cp lib/Software/License/Apache_2_0.pm blib/lib/Software/License/Apache_2_0.pm
cp lib/Software/License/Mozilla_1_1.pm blib/lib/Software/License/Mozilla_1_1.pm
cp lib/Software/License/OpenSSL.pm blib/lib/Software/License/OpenSSL.pm
cp lib/Software/License/GFDL_1_2.pm blib/lib/Software/License/GFDL_1_2.pm
cp lib/Software/License/GPL_3.pm blib/lib/Software/License/GPL_3.pm
cp lib/Software/License/BSD.pm blib/lib/Software/License/BSD.pm
cp lib/Software/License/QPL_1_0.pm blib/lib/Software/License/QPL_1_0.pm
cp lib/Software/License/Artistic_1_0.pm blib/lib/Software/License/Artistic_1_0.pm
cp lib/Software/License/GFDL_1_3.pm blib/lib/Software/License/GFDL_1_3.pm
cp lib/Software/License.pm blib/lib/Software/License.pm
cp lib/Software/License/SSLeay.pm blib/lib/Software/License/SSLeay.pm
cp lib/Software/License/Mozilla_2_0.pm blib/lib/Software/License/Mozilla_2_0.pm
cp lib/Software/License/MIT.pm blib/lib/Software/License/MIT.pm
cp lib/Software/License/CC0_1_0.pm blib/lib/Software/License/CC0_1_0.pm
cp lib/Software/LicenseUtils.pm blib/lib/Software/LicenseUtils.pm
cp lib/Software/License/Custom.pm blib/lib/Software/License/Custom.pm
cp lib/Software/License/GPL_1.pm blib/lib/Software/License/GPL_1.pm
cp lib/Software/License/GPL_2.pm blib/lib/Software/License/GPL_2.pm
cp lib/Software/License/Zlib.pm blib/lib/Software/License/Zlib.pm
cp lib/Software/License/LGPL_3_0.pm blib/lib/Software/License/LGPL_3_0.pm
cp lib/Software/License/Mozilla_1_0.pm blib/lib/Software/License/Mozilla_1_0.pm
cp lib/Software/License/FreeBSD.pm blib/lib/Software/License/FreeBSD.pm
cp lib/Software/License/None.pm blib/lib/Software/License/None.pm
cp lib/Software/License/Apache_1_1.pm blib/lib/Software/License/Apache_1_1.pm
cp lib/Software/License/Artistic_2_0.pm blib/lib/Software/License/Artistic_2_0.pm
cp lib/Software/License/Sun.pm blib/lib/Software/License/Sun.pm
cp lib/Software/License/PostgreSQL.pm blib/lib/Software/License/PostgreSQL.pm
cp lib/Software/License/Perl_5.pm blib/lib/Software/License/Perl_5.pm
cp lib/Software/License/LGPL_2_1.pm blib/lib/Software/License/LGPL_2_1.pm
cp lib/Software/License/AGPL_3.pm blib/lib/Software/License/AGPL_3.pm
Manifying 30 pod documents
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
#·
#·
# Generated by Dist::Zilla::Plugin::ReportVersions::Tiny v1.10
# perl: 5.014002 (wanted 5.006) on linux from /usr/bin/perl
#·
# Carp                                          => 1.36       (want any version)
# Data::Section                                 => 0.200006   (want any version)
# ExtUtils::MakeMaker                           => 7.04       (want 6.30)···
# File::Spec                                    => 3.47       (want any version)
# IO::Dir                                       => 1.07       (want any version)
# Module::Load                                  => 0.18       (want any version)
# Sub::Install                                  => 0.928      (want any version)
# Test::More                                    => 1.001014   (want 0.96)···
# Text::Template                                => 1.46       (want any version)
# Try::Tiny                                     => 0.22       (want any version)
# parent                                        => 0.232      (want any version)
# strict                                        => 1.04       (want any version)
# warnings                                      => 1.12       (want any version)
#·
# Thanks for using my code.  I hope it works for you.
# If not, please try and include this output in the bug report.
# That will help me reproduce the issue and solve your problem.
#·
t/000-report-versions-tiny.t .. ok
t/basic.t ..................... ok
t/bsd-url.t ................... ok
t/custom.t .................... ok

#   Failed test at t/guess_meta_license.t line 57.
#     Structures begin differing at:
#          $got->[1] = 'Software::License::GPL_3_plus'
#     $expected->[1] = Does not exist
# Looks like you failed 1 test of 26.
t/guess_meta_license.t ........·
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/26 subtests·
t/meta-names.t ................ ok
t/round-trip.t ................ ok
t/short_name.t ................ ok

#   Failed test 'guessed okay'
#   at t/utils.t line 123.
#     Structures begin differing at:
#          $got->[1] = 'Software::License::GPL_1_plus'
#     $expected->[1] = 'Software::License::GPL_2'
# Looks like you failed 1 test of 5.
t/utils.t .....................·
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/5 subtests·

Test Summary Report
-------------------
t/guess_meta_license.t      (Wstat: 256 Tests: 26 Failed: 1)
  Failed test:  25
  Non-zero exit status: 1
t/utils.t                   (Wstat: 256 Tests: 5 Failed: 1)
  Failed test:  4
  Non-zero exit status: 1
Files=9, Tests=102,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.47 cusr  0.04 csys =  0.55 CPU)
Result: FAIL
Failed 2/9 test programs. 2/102 subtests failed.
make: *** [test_dynamic] Error 1
  /usr/bin/make test -- NOT OK
Stopping: 'install' failed for 'R/RJ/RJBS/Software-License-0.103010.tar.gz'.

[whamlin]

This bug is a result of the way Software::LicenseUtils iterates over @INC to set up its meta key hashes. If a previous version is installed (in our case, the one provided by libsoftware-license-perl in Ubuntu) that has additional licenses, the tests will fail.

The comment on line 55 of lib/Software/LicenseUtils.pm is on point - testing should only scan lib and blib.

[karenetheridge]

testing should only scan lib and blib

agreed.