Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintegrate option to output intersections in neighbor deduplication #44

Open
julietcohen opened this issue Feb 15, 2024 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@julietcohen
Copy link
Collaborator

julietcohen commented Feb 15, 2024

In the neighbor deduplication, the optional functionality to output the intersections is no longer functional since I updated the way we deduplicate with the first package release. This is documented in the function itself here.

If this functionality cannot be reintegrated in the next package release, it would be ideal to output a warning or more descriptive error message if the user sets the return_intersections argument to True. That way, if the user does not really need the intersections to be output, they can at least know to change the argument to False (the default) and move on with their analysis until the intersections output is functional again.

Returning the intersections is helpful for testing the way the neighbor method deduplicates. This feature would be helpful for Ingmar Nitze's lake change dataset, as noted in issue#36.

@julietcohen julietcohen added the good first issue Good for newcomers label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

1 participant