Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff plugin uses outdated URLs #12

Open
bjoern-reetz opened this issue Sep 24, 2024 · 6 comments
Open

Ruff plugin uses outdated URLs #12

bjoern-reetz opened this issue Sep 24, 2024 · 6 comments

Comments

@bjoern-reetz
Copy link

The Ruff plugin uses out-dated URLs. With v0.5, the maintainers of Ruff dropped the "v"-prefix in their tags & releases. The proto TOML plugin therefore needs to be updated - unfortunately.

@bjoern-reetz
Copy link
Author

If you like, I can also try to submit a pull-request myself.

@Phault
Copy link
Owner

Phault commented Sep 25, 2024

Ah, that's unfortunate. I can't recall if the toml plugin schema supports having multiple formats. If not then it should probably be split into two variants.

I'm not really using proto much anymore, but I'll gladly merge a PR with backwards compatibility.

@bjoern-reetz
Copy link
Author

OK, I think I'll go ask the maintainers of proto what they would suggest in this case.

@bjoern-reetz
Copy link
Author

The maintainers of Proto confirmed that currently, the TOML plugins have no way of resolving to different URLs depending on the tool's version.

@bjoern-reetz
Copy link
Author

If you don't mind, I would create a TOML plugin with support for Ruff >= 0.5.0 myself in another Git repository and submit a new plugin URL to moonrepo, so that users of proto find a plugin which supports the latest versions of Ruff when they do proto plugin search ruff or visit the supported tools page.

Are you fine with that?

@Phault
Copy link
Owner

Phault commented Oct 1, 2024

The maintainers of Proto confirmed that currently, the TOML plugins have no way of resolving to different URLs depending on the tool's version.

That's unfortunate. :(

If you don't mind, I would create a TOML plugin with support for Ruff >= 0.5.0 myself in another Git repository and submit a new plugin URL to moonrepo, so that users of proto find a plugin which supports the latest versions of Ruff when they do proto plugin search ruff or visit the supported tools page.

Are you fine with that?

Of course! But I appreciate that you asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants