Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider our Dependabot upgrade experience #19

Open
reefdog opened this issue Apr 1, 2024 · 2 comments
Open

Consider our Dependabot upgrade experience #19

reefdog opened this issue Apr 1, 2024 · 2 comments

Comments

@reefdog
Copy link

reefdog commented Apr 1, 2024

Dependabot is telling people about the SDK upgrades, including… us! Whee! Here's the PR that it just opened on the front-end:

PhilanthropyDataCommons/front-end#656

Lacking from the output which some other (but not all) Dependabot PRs have:

  • Release notes
  • Changelog
  • Commits

I'll bet we don't generate some of those, and maybe shouldn't/won't. But as an SDK user, when notified by Dependabot of an update, I would like some useful call to action to inspect what changed. I leave it to the room to discuss what's right for this project.

@reefdog
Copy link
Author

reefdog commented May 6, 2024

Bumping this, not for immediate resolution but just because it's probably worthwhile to +1 anytime it has a noticeable impact.

Even as a PDC dev, I'm not always plugged into the SDK update cycle / what comes with each version. I know where to find it (https://github.com/PhilanthropyDataCommons/service/blob/main/CHANGELOG.md), but I shouldn't have to. It would be much more intuitive for the Dependabot PR to have some way of getting to the changelog so I can see just what I'm upgrading and why.

I know our SDK deployment process might make this a real hassle if not impossible. But still, it's a real need that our SDK users will have as well, so I'll keep politely beeping the horn.

@reefdog
Copy link
Author

reefdog commented May 6, 2024

Wait… I'm even more confused just now…

That PR bumps @pdc/sdk from 0.9.1 to 0.9.2. But of course those version numbers don't mean anything in the context of this repo. I thought tracking it back to the service repo would illuminate, but service's main branch only seems to be on 0.9.1. What is 0.9.2?

Moved this to a separate and more focused issue: #23

@slifty slifty self-assigned this Jul 10, 2024
@slifty slifty added this to Phase 5 Jul 10, 2024
@slifty slifty moved this to Later in Phase 5 Jul 11, 2024
@slifty slifty removed their assignment Jul 11, 2024
@slifty slifty moved this from Later to Todo in Phase 5 Sep 10, 2024
@slifty slifty moved this from Todo to Later in Phase 5 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Later
Development

No branches or pull requests

2 participants