Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork multi user macro reusability / reconfigurability #2

Closed
Phoscur opened this issue Apr 8, 2023 · 3 comments · Fixed by #3
Closed

Fork multi user macro reusability / reconfigurability #2

Phoscur opened this issue Apr 8, 2023 · 3 comments · Fixed by #3

Comments

@Phoscur
Copy link
Owner

Phoscur commented Apr 8, 2023

Following up on gittyeric#7
We need to stop comment out eachothers macros.

I want to refactor

  • extract my-macros.ts per user macros/<username> - add feature flags to enable loading multiple macro collections
  • move macros.ts into src folder
@Phoscur Phoscur mentioned this issue Apr 9, 2023
Merged
@Phoscur Phoscur changed the title Fork multi user macro reusablitiy / reconfigurability Fork multi user macro reusablity / reconfigurability Apr 12, 2023
@Phoscur Phoscur changed the title Fork multi user macro reusablity / reconfigurability Fork multi user macro reusability / reconfigurability Apr 12, 2023
@Phoscur
Copy link
Owner Author

Phoscur commented Apr 12, 2023

@sytone please check this out!
Do we want to go for TypeScript Strict Mode too?

@sytone
Copy link

sytone commented Apr 13, 2023

Pulling it today to have a look, I see typescript is not happy with the unsafe assignments, a refactor to classes and interfaces would clean that up if you want to go to strict.

@Phoscur
Copy link
Owner Author

Phoscur commented Apr 13, 2023 •
edited
Loading

You are reading my mind :) There are also missing tests for some special parts:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add macro config per user, refactor & add tests Phoscur/oryx-macro-hax
2 participants
@Phoscur @sytone