New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static IP can be outside of comp-legal range #1750

Open

mcm001 opened this issue Jan 27, 2025 · 5 comments · May be fixed by #1751

Labels

bug

Contributor

mcm001 commented Jan 27, 2025

IS: static IP address regex simply checks if the IP address looks like an IPv4 address
https://github.com/PhotonVision/photonvision/blob/78b82e3a96d04f79e0b70746dd975c10c8ff1294/photon-client/src/components/settings/NetworkingCard.vue#L33C1-L39C3
https://stackoverflow.com/a/17871737

Should Be: static IP regex checks if on the comp legal range. for 2025, .6-.19 is legal.

mcm001 added the bug label

Contributor Author

mcm001 commented Jan 27, 2025

regexr.com/8beu1 suggests that ^((25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])\.){3,3}0?(1[0-9]|10)$ works.

mcm001 linked a pull request

that will close this issue

Tighten static ip regex #1751

Open

Contributor

TheTripleV commented Jan 27, 2025

Nit but .220 and up is also technically allowed. https://docs.wpilib.org/en/stable/docs/networking/networking-introduction/ip-configurations.html#on-the-field-dhcp-configuration

Contributor Author

mcm001 commented Jan 27, 2025

Should we allow users to set that? Surely .6 to .19 will be enough for anyone.

Contributor

TheTripleV commented Jan 27, 2025

No, you're right

Contributor Author

mcm001 commented Jan 27, 2025

good to know for later down the road i guess if Redux puts everything on ethercat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment