diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java index 78d531fbe1..bc5462092b 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java @@ -988,34 +988,26 @@ Flux after(Flux flux) { /** Prefer {@link Mono#ofType(Class)} over more contrived alternatives. */ static final class MonoOfType { @BeforeTemplate - Mono before(Mono mono) { - return mono.filter( - Refaster.anyOf( - Refaster.clazz()::isInstance, - x -> Refaster.clazz().isAssignableFrom(x.getClass()))) - .cast(Refaster.clazz()); + Mono before(Mono mono, Class clazz) { + return mono.filter(clazz::isInstance).cast(clazz); } @AfterTemplate - Mono after(Mono mono) { - return mono.ofType(Refaster.clazz()); + Mono after(Mono mono, Class clazz) { + return mono.ofType(clazz); } } /** Prefer {@link Flux#ofType(Class)} over more contrived alternatives. */ static final class FluxOfType { @BeforeTemplate - Flux before(Flux flux) { - return flux.filter( - Refaster.anyOf( - Refaster.clazz()::isInstance, - x -> Refaster.clazz().isAssignableFrom(x.getClass()))) - .cast(Refaster.clazz()); + Flux before(Flux flux, Class clazz) { + return flux.filter(clazz::isInstance).cast(clazz); } @AfterTemplate - Flux after(Flux flux) { - return flux.ofType(Refaster.clazz()); + Flux after(Flux flux, Class clazz) { + return flux.ofType(clazz); } } diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java index 8b5a36885a..ddb96926b6 100644 --- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java +++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java @@ -333,16 +333,12 @@ Flux testFluxCast() { return Flux.just(1).map(Number.class::cast); } - ImmutableSet> testMonoOfType() { - return ImmutableSet.of( - Mono.just(1).filter(Number.class::isInstance).cast(Number.class), - Mono.just(2).filter(n -> Number.class.isAssignableFrom(n.getClass())).cast(Number.class)); + Mono testMonoOfType() { + return Mono.just(1).filter(Number.class::isInstance).cast(Number.class); } - ImmutableSet> testFluxOfType() { - return ImmutableSet.of( - Flux.just(1).filter(Number.class::isInstance).cast(Number.class), - Flux.just(2).filter(n -> Number.class.isAssignableFrom(n.getClass())).cast(Number.class)); + Flux testFluxOfType() { + return Flux.just(1).filter(Number.class::isInstance).cast(Number.class); } Mono testMonoFlatMap() { diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java index 5ba505b714..35ad88b6fe 100644 --- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java +++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java @@ -326,12 +326,12 @@ Flux testFluxCast() { return Flux.just(1).cast(Number.class); } - ImmutableSet> testMonoOfType() { - return ImmutableSet.of(Mono.just(1).ofType(Number.class), Mono.just(2).ofType(Number.class)); + Mono testMonoOfType() { + return Mono.just(1).ofType(Number.class); } - ImmutableSet> testFluxOfType() { - return ImmutableSet.of(Flux.just(1).ofType(Number.class), Flux.just(2).ofType(Number.class)); + Flux testFluxOfType() { + return Flux.just(1).ofType(Number.class); } Mono testMonoFlatMap() {