Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position shift when looking straight up or down #201

Open
fenhl opened this issue Feb 28, 2015 · 3 comments
Open

Position shift when looking straight up or down #201

fenhl opened this issue Feb 28, 2015 · 3 comments
Labels
bug

Comments

@fenhl
Copy link
Member

fenhl commented Feb 28, 2015

When looking straight up or down, the position of the camera appears to shift forward by about 2 pixels.
@fenhl fenhl added the bug label Feb 28, 2015
RichardlL added a commit to RichardlL/hematite that referenced this issue Dec 6, 2015
@RichardlL
Fixed Camera shifting Bug
b13d9aa 
See Bug: PistonDevelopers#201

Fixed  Camera  X/Y changing when Pitch/Yaw is at Min and max
@RichardlL RichardlL mentioned this issue Dec 6, 2015
Merged
@RichardlL
Copy link
Contributor

Pull request:

#250

@bvssvni
Copy link
Member

bvssvni commented Dec 6, 2015

Fixed by #250

@bvssvni bvssvni closed this as completed Dec 6, 2015
@eddyb
Copy link
Contributor

eddyb commented Dec 7, 2015

Wrong fix, the problem is that camera.forward can have x and z equal to 0, i.e. looking straight up or down, which is... maybe not incorrect, but the camera still needs to always preserve a horizontal direction to be minecraft-like.
Which would be the yaw, I believe. Extracting that and using it for the xz_forward offset #250 effectively removed should do the trick.

@eddyb eddyb reopened this Dec 7, 2015
RichardlL added a commit to RichardlL/hematite that referenced this issue Dec 7, 2015
@RichardlL
Another camera Shifting bug update
8b6c9fa 
Closes  PistonDevelopers#201
Closes PistonDevelopers#251

See my explanation here:
PistonDevelopers#251 (comment)
@RichardlL RichardlL mentioned this issue Dec 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eddyb @fenhl @bvssvni @RichardlL