Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move here GL init from window back-ends. #164

Open
5 tasks
Potpourri opened this issue Apr 9, 2015 · 4 comments
Open
5 tasks

Move here GL init from window back-ends. #164

Potpourri opened this issue Apr 9, 2015 · 4 comments
Assignees
Labels

Comments

@Potpourri
Copy link
Member

See PistonDevelopers/window#56

  • Add second argument (&mut W where W: OpenGLWindow) to GlGraphics::new and add GL init inside it
  • Remove GL init from window back-ends:
    • sdl2_window
    • glfw_window
    • glutin_window
@Potpourri Potpourri added the draft label Apr 9, 2015
@Potpourri Potpourri self-assigned this Apr 9, 2015
@bvssvni
Copy link
Member

bvssvni commented Apr 10, 2015

There is a problem when you are using OpenGL for other things than 2D, or if you are using different shaders for 2D. I'd like to separate this step from the creation of Gl.

@kvark
Copy link
Member

kvark commented Apr 10, 2015

I don't like run-time argument here, because:

  • you always know in advance
  • no need to link and compile multiple instances of gl-rs

@bvssvni
Copy link
Member

bvssvni commented Apr 10, 2015

@kvark What do you mean with "run-time argument"?

@kvark
Copy link
Member

kvark commented Apr 10, 2015

You proposed to add a switch to the WindowSettings here. This would be a run-time switch, so all the gl is still going to be linked and compiled. I vote for either removal, or making it a cargo configuration flag (compile switch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants