Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing data in wolf and cat death logs #648

Open
AbigailBrady opened this issue Sep 26, 2024 · 0 comments
Open

missing data in wolf and cat death logs #648

AbigailBrady opened this issue Sep 26, 2024 · 0 comments

Comments

@AbigailBrady
Copy link

Testing on our 1.21.1 server that has CoreProtect 23.1 installed and discovered that wolf variants (new to MC 1.20.5) are not serialised.

in EntityDeathListener.java we have

            info.add(BukkitAdapter.ADAPTER.getRegistryKey(cat.getCatType()));

for cats but nothing equivalent for wolves. Also, while looking at this, I realised that it does have this line for dogs:

            info.add(wolf.isSitting());

which is missing in cats, as cats can sit as well. I then confirmed this by killing a sat cat and restoring - it restored unsat.

It might be worth doing a full scan to see if there is anything else that is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant