Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use purescript-cip30-typesafe #1583

Merged
merged 6 commits into from
Jan 6, 2024
Merged

Use purescript-cip30-typesafe #1583

merged 6 commits into from
Jan 6, 2024

Conversation

klntsky
Copy link
Contributor

@klntsky klntsky commented Dec 20, 2023

Closes #1582

Pre-review checklist

  • All code has been formatted using our config (make format)
  • Any new API features or modification of existing behavior is covered as defined in our test plan
  • The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

@klntsky klntsky requested a review from errfrom December 21, 2023 14:58
errfrom
errfrom approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@errfrom errfrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor suggestions below, mostly stylistic, apply at your discretion

@klntsky klntsky merged commit 64bc1bf into develop Jan 6, 2024
1 check passed
@klntsky klntsky deleted the klntsky/use-cip30 branch January 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errfrom errfrom errfrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a wrapper over purescript-cip30
2 participants
@klntsky @errfrom