Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract blockfrost provider #1675

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

KristianBalaj
Copy link
Collaborator

@KristianBalaj KristianBalaj commented Feb 19, 2025

Closes #1661.

Related PRs:

Pre-review checklist

  • All code has been formatted using our config (make format)
  • Any new API features or modification of existing behavior are covered with tests
  • The template (templates/ctl-scaffold) has been updated
  • The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Changed, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

@KristianBalaj
Copy link
Collaborator Author

KristianBalaj commented Feb 19, 2025

TODO:

  • update spago dependencies once dependent packages approved

@KristianBalaj KristianBalaj changed the title [WIP] Extract blockfrost provider Extract blockfrost provider Feb 19, 2025
@KristianBalaj KristianBalaj marked this pull request as ready for review February 19, 2025 18:21
(wrap stakeValidatorHash)
)
}
Blockfrost.providerForBlockfrostBackend runBlockfrostServiceM'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but ideally users should be able to import specific providers directly from their respective packages

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I know, however the problem here is it's injecting CTL logging into the provider and that's something the blockfrost package itself can't do, because of that this reexport in CTL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Blockfrost Provider to a separate package
3 participants