-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract blockfrost provider #1675
base: develop
Are you sure you want to change the base?
Conversation
…-lib into blockfrost-provider-extraction
TODO:
|
(wrap stakeValidatorHash) | ||
) | ||
} | ||
Blockfrost.providerForBlockfrostBackend runBlockfrostServiceM' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but ideally users should be able to import specific providers directly from their respective packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I know, however the problem here is it's injecting CTL logging into the provider and that's something the blockfrost package itself can't do, because of that this reexport in CTL.
They were removed in some previous commit.
Co-authored-by: Dzmitry Shuiski <[email protected]>
Closes #1661.
Related PRs:
Pre-review checklist
make format
)templates/ctl-scaffold
) has been updated## Unreleased
header, using the appropriate sub-headings (### Added
,### Changed
,### Removed
,### Fixed
), and the links to the appropriate issues/PRs have been included