Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid $required parameter value: '1' . It must be either VALUE_DEFAULT, VALUE_REQUIRED, or VALUE_OPTIONAL #507

Closed
opitz opened this issue Sep 12, 2023 · 0 comments
Closed

Invalid $required parameter value: '1' . It must be either VALUE_DEFAULT, VALUE_REQUIRED, or VALUE_OPTIONAL #507

opitz opened this issue Sep 12, 2023 · 0 comments

Comments

@opitz
Copy link
Contributor

opitz commented Sep 12, 2023

PHP 8.0 throws a warning as a parameter does not follow coding standards

To fix this line 133 of mod/questionnaire/externallib.php needs to change from

'submitted' => new \external_value(PARAM_BOOL, 'submitted', true, false, false),

to

'submitted' => new \external_value(PARAM_BOOL, 'submitted', VALUE_REQUIRED, false, false),
opitz pushed a commit to opitz/moodle-mod_questionnaire that referenced this issue Sep 12, 2023
using valid $required parameter VALUE_REQUIRED - fixes PoetOS#507
ad7ac72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@opitz