-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving focus to next item (in paper-menu) does not skip disabled items #57
Comments
(partial recap from offline discussion) Here's another PR that's been open on IronSelectableBehavior about supporting a 'disabled' attribute: PolymerElements/iron-selector#107. My main concern with it is that 'disabled' and 'selectable' are different: I think 'disabled' implies what the end user can do, but that it shouldn't prevent the API user from changing the selected state of a 'disabled' item. Maybe the concept of 'disabled' is better handled at the level of IronMenuBehavior? (Or somewhere else higher up than IronSelectableBehavior?) |
…oes not skip disabled items. We are looking at the 'disabled' html dom attribute rather then the iron-control-state 'disabled' property for more generic support.
…oes not skip disabled items. We are looking at the 'disabled' html dom attribute rather then the iron-control-state 'disabled' property for more generic support.
Fixing #57 Moving focus to next item (in paper-menu) does not skip disabled items.
#58 has been merged. This behavior is enabled in v1.1.6 . |
Description
When using 'paper-menu' where one of the 'paper-item's is disabled, traversing the items using up/down keyboard keys or typing the first letter of one of the item's titles does not skip disabled paper-items.
Expected outcome
Disabled paper-items should not be focus-able and should be ignored when using the following methods: _focusNext, _focusPrevious, focusWithKeyboardEvent in IronMenuBehaviorImpl.
Actual outcome
focusNext/focusPrevious should skip disabled paper-items.
Steps to reproduce
Browsers Affected
The text was updated successfully, but these errors were encountered: