Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize parsing of schema field types #7127

Open
shans opened this issue Apr 26, 2021 · 0 comments
Open

Generalize parsing of schema field types #7127

shans opened this issue Apr 26, 2021 · 0 comments

Comments

@shans
Copy link
Contributor

shans commented Apr 26, 2021

(from b/157522096)

A lot of types in the schema are needlessly strict - for example CollectionType only allows PrimitiveType or KotlinType as the inner type; UnionType only allows PrimitiveTypes to be unioned.

Part of this is probably to avoid awkwardness ([[Long]] isn't something we can handle yet) but we shouldn't be detecting this at the parsing stage. Unless there's a really good reason for it, we should recurse back to the top level SchemaType production where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant