Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface sensitive pattern as a configurable option #4197

Open
1 task done
kilasuit opened this issue Sep 29, 2024 · 0 comments
Open
1 task done

Surface sensitive pattern as a configurable option #4197

kilasuit opened this issue Sep 29, 2024 · 0 comments
Labels
Issue-Enhancement It's a feature request. Needs-Triage 🔍 It's a new issue that core contributor team needs to triage.

Comments

@kilasuit
Copy link

Prerequisites

  • Write a descriptive title.

Description of the new feature/enhancement

we currently have this regex pattern hardcoded & this could be useful for further extensibility going forward.

private static readonly Regex s_sensitivePattern = new Regex(
"password|asplaintext|token|apikey|secret",
RegexOptions.Compiled | RegexOptions.IgnoreCase);

Therefore it would be great to surface extensibility of this via either

  1. fully configurable option with this pattern as the default setting
  2. setable property for addtional patterns to match

2 I feel is a better & more secureminded implementation going forward & would enable users to manage asks like #4077 (which we perhaps could pull into the default's as part of this enhancement

Proposed technical implementation details (optional)

No response

@kilasuit kilasuit added the Issue-Enhancement It's a feature request. label Sep 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement It's a feature request. Needs-Triage 🔍 It's a new issue that core contributor team needs to triage.
Projects
None yet
Development

No branches or pull requests

1 participant