Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default value for project/@stage #682

Open
Alex-Jordan opened this issue Feb 9, 2024 · 2 comments
Open

default value for project/@stage #682

Alex-Jordan opened this issue Feb 9, 2024 · 2 comments

Comments

@Alex-Jordan
Copy link
Contributor

In a project file, the default value for project/@output-dir is output. And the default value for project/@stage is output/stage. If you override the first default, with say project/@output-dir="myoutput" and then you deploy, it creates an output/stage/ folder (creating the intermediate output/ folder) and now your file tree has both output/ and myoutput/.

Thoughts on making stage just not be a subfolder of output?

@StevenClontz
Copy link
Member

Hot take, I forget why we put the default stage in output (maybe just to be lazy with gitignores), but I think having stage as a sibling of output makes sense.

@oscarlevin
Copy link
Member

I don't love having another root-level folder for this, as for most users currently, stage will be identical to output/web. I think having both will be confusing.

No reason we can't get the location of stage to be relative to the value of project/@stage with default being the stage subdirectory of the actual project/@output directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants