Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Change all api routes to use proper names for IDs #56

Open
2 tasks done
scottdykes1611 opened this issue May 29, 2024 · 0 comments
Open
2 tasks done
Assignees
Labels

Comments

@scottdykes1611
Copy link

Product

Sensabill

Is your feature request related to a problem? Please describe.

In API routes, "id" is often used where "clientId" or "supplierId" (etc.) should be used instead

These ids are therefore not used in auth middleware

Describe the solution you'd like.

  • Change all IDs to use the proper name: such as "clientId"
  • Do rigorous testing to make sure everything still works as it should for all user types

Describe alternatives you've considered.

No response

Checked for existing ticket

  • I confirm I have checked to see that this feature has not already been requested.
  • I confirm I have not included any sensitive information.
@github-project-automation github-project-automation bot moved this to Needs Refinement in Scrum May 29, 2024
@scottdykes1611 scottdykes1611 self-assigned this May 29, 2024
@scottdykes1611 scottdykes1611 moved this from Needs Refinement to In Progress in Scrum May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

1 participant