Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

添加出演角色相关单页 #690

Open
Predidit opened this issue Feb 3, 2025 · 4 comments
Open

添加出演角色相关单页 #690

Predidit opened this issue Feb 3, 2025 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Predidit
Copy link
Owner

Predidit commented Feb 3, 2025

当前 Bangumi API 允许我们构建角色介绍单页

单页包括角色介绍以及出演番剧

我们可以考虑重构当前番剧详情中的角色表

以到相关单页的调整取代现在的展开的简单介绍
@Predidit Predidit added enhancement New feature or request good first issue Good for newcomers labels Feb 3, 2025
@Predidit Predidit pinned this issue Feb 3, 2025
@ErBWs
Copy link
Contributor

ErBWs commented Feb 3, 2025

我的 feat-character-info 分支还没删

从 bangumi api 获取角色条目的函数应该能用得上

不过要做单页的话，也许可以把视频源选择和现在的 BottomSheet 内容互换一下，我感觉这样逻辑上更好（详情页会更像 bangumi。当然这只是我的一点建议。

@Predidit
Copy link
Owner Author

Predidit commented Feb 3, 2025

那样的话确实逻辑好多了

你愿意做这件事吗

@ErBWs
Copy link
Contributor

ErBWs commented Feb 3, 2025

我可以试试，但我不一定有时间

@Predidit
Copy link
Owner Author

Predidit commented Feb 3, 2025

确实，这是一个相当大的工程

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Predidit @ErBWs