Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prometheus-prefect-exporter to be used as a sub-chart #311

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

StephenRobin
Copy link
Contributor

Helm adds a property called "global" when a chart is being used as a sub-chart. This must be allowed for in the schema or validation will fail.

The prefect-server and prefect-worker charts already have this defined but it's missing from prometheus-prefect-exporter.

Helm adds a property called "global" when a chart is being used as a sub-chart. This must be allowed for in the schema or validation will fail.

The prefect-server and prefect-worker charts already have this defined but it's missing from prometheus-prefect-exporter.
@StephenRobin StephenRobin requested a review from a team as a code owner March 14, 2024 13:11
@jamiezieziula jamiezieziula merged commit 5101406 into PrefectHQ:main Mar 20, 2024
16 checks passed
@jamiezieziula jamiezieziula added the enhancement An improvement of an existing feature label Mar 20, 2024
@StephenRobin StephenRobin deleted the patch-1 branch May 2, 2024 20:55
@FabioBatSilva
Copy link

Was this ever release ?

The latest version i can find (2023.12.7), doesn't seem to include it.

helm search repo prometheus-prefect-exporter
NAME                               	CHART VERSION	APP VERSION	DESCRIPTION                                       
prefect/prometheus-prefect-exporter	2023.12.7    	1.0.0      	A Helm chart to deploy Prometheus Prefect Exporter

@jamiezieziula jamiezieziula added exporter and removed enhancement An improvement of an existing feature labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants