Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support seccompProfile attribute in the worker chart. #429

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

acarmel
Copy link
Contributor

@acarmel acarmel commented Jan 22, 2025

This commit adds a seccompProfile attribute support for podSecurityContext in the worker chart similarly to what is done in this PR #424. Defaults to kubernetes default value RuntimeDefault.

@acarmel acarmel requested a review from a team as a code owner January 22, 2025 12:08
Copy link
Contributor

@jamiezieziula jamiezieziula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit on the values comment

@@ -206,6 +206,11 @@ worker:
runAsNonRoot: true
# -- set worker pod's security context fsGroup
fsGroup: 1001
# -- set server pod's seccomp profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# -- set server pod's seccomp profile
# -- set worker pod's seccomp profile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. thanks for catching that

This commit adds a seccompProfile attribute support for
podSecurityContext in the worker chart similarly to what is done
in this PR PrefectHQ#424.
Defaults to kubernetes default value RuntimeDefault.
@jamiezieziula jamiezieziula merged commit 9c166aa into PrefectHQ:main Jan 22, 2025
13 checks passed
@jamiezieziula jamiezieziula added the enhancement An improvement of an existing feature label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants