Refresh session when deleting schedules off a deployment (#17278)

PrefectHQ · Feb 27, 2025 · c5eef21 · c5eef21
1 parent b498b9d
commit c5eef21
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/src/prefect/server/models/deployments.py b/src/prefect/server/models/deployments.py
@@ -1012,12 +1012,16 @@ async def delete_schedules_for_deployment(
         deployment_id: a deployment id
     """
 
+    deployment = await session.get(db.Deployment, deployment_id)
+    assert deployment is not None
+
     result = await session.execute(
         sa.delete(db.DeploymentSchedule).where(
             db.DeploymentSchedule.deployment_id == deployment_id
         )
     )
 
+    await session.refresh(deployment)
     return result.rowcount > 0
 
 

diff --git a/tests/server/orchestration/api/test_deployments.py b/tests/server/orchestration/api/test_deployments.py
@@ -1516,6 +1516,45 @@ async def test_paginate_deployments_returns_empty_list(self, client):
 
 
 class TestUpdateDeployment:
+    async def test_update_deployment_with_schedule_allows_addition_of_concurrency(
+        self, client, deployment
+    ):
+        """
+        Regression test for https://github.com/PrefectHQ/prefect/issues/17227
+        """
+        # ensure there's a schedule
+        update_data = DeploymentUpdate(
+            schedules=[
+                schemas.actions.DeploymentScheduleUpdate(
+                    schedule=schemas.schedules.IntervalSchedule(
+                        interval=datetime.timedelta(days=1)
+                    ),
+                    active=True,
+                )
+            ]
+        ).model_dump(mode="json", exclude_unset=True)
+
+        response = await client.patch(f"/deployments/{deployment.id}", json=update_data)
+        assert response.status_code == 204
+
+        # no slug so that it deletes and recreates the schedule
+        update_again = DeploymentUpdate(
+            schedules=[
+                schemas.actions.DeploymentScheduleUpdate(
+                    schedule=schemas.schedules.IntervalSchedule(
+                        interval=datetime.timedelta(days=1)
+                    ),
+                    active=True,
+                )
+            ],
+            concurrency_limit=4,  # add a limit
+        ).model_dump(mode="json", exclude_unset=True)
+
+        response = await client.patch(
+            f"/deployments/{deployment.id}", json=update_again
+        )
+        assert response.status_code == 204
+
     async def test_update_deployment_enforces_parameter_schema(
         self,
         deployment_with_parameter_schema,