Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX confuse about the pip package on UI #16273

Open
adrianoresende opened this issue Dec 9, 2024 · 2 comments
Open

UX confuse about the pip package on UI #16273

adrianoresende opened this issue Dec 9, 2024 · 2 comments
Labels
enhancement An improvement of an existing feature

Comments

@adrianoresende
Copy link
Contributor

Describe the current behavior

I'm trying to add the list pip package, but the placeholder is suggesting using separator with ",":
image

But, after adding the same example of placeholder, an error appeared:
image

I can't find the actual format on the document.

Which Is the correct value, like a list or object type?

Describe the proposed behavior

Fix the placeholder or fix the message error

Example Use

No response

Additional context

No response

@adrianoresende adrianoresende added the enhancement An improvement of an existing feature label Dec 9, 2024
@aaazzam
Copy link
Collaborator

aaazzam commented Dec 9, 2024

Hey @adrianoresende! Thanks for catching this. This bug was fixed checks watch 8 minutes ago, haha.

Should be wrapped in quotes, i.e. "prefect>=3.0.0, marvin" instead of what was display prefect>=3.0.0, marvin

Closed in PrefectHQ/prefect-ui-library#2850

@adrianoresende
Copy link
Contributor Author

Hey @adrianoresende! Thanks for catching this. This bug was fixed checks watch 8 minutes ago, haha.

Should be wrapped in quotes, i.e. "prefect>=3.0.0, marvin" instead of what was display prefect>=3.0.0, marvin

Closed in PrefectHQ/prefect-ui-library#2850

I tried using quotes, but I'm getting an error.

Could not load job configuration: 1 validation error for PrefectManagedPoolWorkerJobConfiguration
pip_packages
  Input should be a valid list [type=list_type, input_value='"prefect>=3.1.5, beautif...up4, requests, smtplib"', input_type=str]
    For further information visit https://errors.pydantic.dev/2.9/v/list_type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants