Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Adds EmptyState for Task Run Concurrency Limits #16203

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Dec 3, 2024

  1. Adds EmptyState for Task Run Concurrency Limits
  2. Adds simple tests for component callback
  3. Adds docs entry

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Related to #15512

@devinvillarosa devinvillarosa marked this pull request as ready for review December 3, 2024 23:46
};
export const TaskRunConcurrencyLimitEmptyState = ({ onClick }: Props) => (
<EmptyState>
<EmptyStateIcon id="CircleArrowOutUpRight" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random thought: does defining the icon by ID like this affect tree shaking for react-lucide?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so: https://lucide.dev/guide/packages/lucide-react#one-generic-icon-component

I think the next followup PR, we can create a list of Icons only available to the ui using its direct imports.

And then we can create a Record of ui-v2's Icons and export it that way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, that sounds like a good way to abstract icon stuff and make it easy to introduce icons from other sources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing in this PR: #16208

@devinvillarosa devinvillarosa force-pushed the add-task-run-concurrency-limit-empty-state branch from 988b443 to c85b81b Compare December 4, 2024 06:04
@devinvillarosa devinvillarosa added development Tech debt, refactors, CI, tests, and other related work. ui Related to the Prefect web interface labels Dec 4, 2024
@devinvillarosa devinvillarosa merged commit d47081f into main Dec 4, 2024
6 of 7 checks passed
@devinvillarosa devinvillarosa deleted the add-task-run-concurrency-limit-empty-state branch December 4, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work. ui Related to the Prefect web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants