[UI v2] feat: Adds flow run data table filter components #17148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinvillarosa
requested review from
aaazzam,
desertaxle,
devangrose and
pleek91
as code owners
devinvillarosa
force-pushed
the
start-flow-run-table-filters
branch
from
e3aa54a to
91408cd
Compare
devangrose
approved these changes
Feb 18, 2025
| ) { | ||
| return false; | ||
| } | ||
| return Array.from(selectedFilters).every((filter) => |
There was a problem hiding this comment.
nice, didn't know these functions existed
| ); | ||
| }, [selectedFilters]); | ||
|
|
||
| const handleSelectAllExceptScheduled = () => { |
There was a problem hiding this comment.
Could these be reduced to use the handleSelectFilter function?
There was a problem hiding this comment.
hmm, I can' think of how to do it while keeping it readable.
Mostly because these type of filter selections are deriving the state of multiple filters 🤔
devinvillarosa
force-pushed
the
start-flow-run-table-filters
branch
from
91408cd to
826eaad
Compare
devangrose
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds filtering components to be used for the flow run data table
Screen.Recording.2025-02-14.at.3.11.48.PM.mov
Checklist
<link to issue>"mint.json.Relates to #15512