Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Integrate flow run row deletion to data table #17196

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 19, 2025

Integrates flow run row deletion to data table

Screen.Recording.2025-02-19.at.10.13.57.AM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 19, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review February 19, 2025 18:17
@pleek91
Copy link
Contributor

pleek91 commented Feb 19, 2025

We probably want to style the column so it takes up the minimum width necessary. Right now it looks like its pushing the name column over quite a bit.

Also can we use the indeterminate state for the select all checkbox when some but not all rows are selected?

@devinvillarosa
Copy link
Contributor Author

We probably want to style the column so it takes up the minimum width necessary. Right now it looks like its pushing the name column over quite a bit.

Also can we use the indeterminate state for the select all checkbox when some but not all rows are selected?

Sounds good. Let me update it.
The shadcn docs didn't specify how to do indeterminate state, but I just found an youtube short on how to do it 🤣

@devinvillarosa
Copy link
Contributor Author

We probably want to style the column so it takes up the minimum width necessary. Right now it looks like its pushing the name column over quite a bit.

Also can we use the indeterminate state for the select all checkbox when some but not all rows are selected?

Updated PR:
https://github.com/user-attachments/assets/0c25976f-525d-4e91-9a9d-9da5dee210fb

@devinvillarosa devinvillarosa force-pushed the devin/eng-1405-integrate-deletion branch from d03ed0f to 454ea36 Compare February 19, 2025 18:40
@devinvillarosa devinvillarosa merged commit 2e21fae into main Feb 19, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the devin/eng-1405-integrate-deletion branch February 19, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants