Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Adds search, sort, filtering, and pagination functionality to data table #17205

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 19, 2025

Adds search, sort, filtering, and pagination functionality to data table.
Next step is to integrate this UI component to a route with search params

Opting to not test too much on these feature on the data table component, because tests are already written per component. Trying to avoid redundant tests

Screen.Recording.2025-02-19.at.1.14.55.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 19, 2025
@devinvillarosa devinvillarosa force-pushed the devin/eng-1279-deploymentid-upcoming-tab-add-runs-list-section branch from 27edb66 to 00d03e5 Compare February 19, 2025 21:21
@devinvillarosa devinvillarosa marked this pull request as ready for review February 19, 2025 21:22
@devinvillarosa devinvillarosa force-pushed the devin/eng-1279-deploymentid-upcoming-tab-add-runs-list-section branch from 00d03e5 to b4de7ea Compare February 19, 2025 21:26
@devinvillarosa devinvillarosa force-pushed the devin/eng-1279-deploymentid-upcoming-tab-add-runs-list-section branch from b4de7ea to cd7bbee Compare February 19, 2025 21:41
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@devinvillarosa devinvillarosa merged commit 4497d93 into main Feb 19, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the devin/eng-1279-deploymentid-upcoming-tab-add-runs-list-section branch February 19, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants