Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Re-adds Alert Dialog to get updated shadcn version for tailwind 4 upgrade #17270

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[UI v2] feat: Re-adds Alert Dialog to get updated shadcn version for tailwind 4 upgrade #17270

merged 1 commit into from
Feb 25, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 25, 2025 •
edited
Loading

Missed re-updating AlertDialog to fix the dialog animation bug that occured when upgrading to tailwind 4

Screen.Recording.2025-02-24.at.8.59.08.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 25, 2025
devinvillarosa
devinvillarosa commented Feb 25, 2025
View reviewed changes
ui-v2/src/components/ui/alert-dialog.tsx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ran npx shadcn@latest add alert-dialog, which gives the latest version from shadcn. This version supports tailwind 4 and React 19

@devinvillarosa devinvillarosa marked this pull request as ready for review February 25, 2025 05:01
desertaxle
desertaxle approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@devinvillarosa devinvillarosa merged commit 4f96bde into main Feb 25, 2025
6 checks passed
@devinvillarosa devinvillarosa deleted the upgrade-alerts-dialog branch February 25, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@devangrose devangrose Awaiting requested review from devangrose devangrose is a code owner

@pleek91 pleek91 Awaiting requested review from pleek91 pleek91 is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @desertaxle