Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds work-pool-select component #17291

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[UI v2] feat: Adds work-pool-select component #17291

merged 1 commit into from
Feb 26, 2025
+256 −0

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 26, 2025 •
edited
Loading

Adds WorkPoolSelect component.

This component is used for selecting a Deployment's workpool when editing or duplicating

Screen.Recording.2025-02-26.at.9.41.03.AM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 26, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review February 26, 2025 17:43
pleek91
pleek91 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but LGTM!

ui-v2/src/components/work-pools/work-pool-select/work-pool-select.tsx
};

type WorkPoolSelectProps = {
presetOptions?: Array<PresetOption>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are preset options for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some UX where I've seen that None is an option.
And for the automations, there's an Infer option.

Adding this option just in case this component can fit the above use cases

@devinvillarosa devinvillarosa merged commit 4d9c0d2 into main Feb 26, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the work-pools-select branch February 26, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@devangrose devangrose Awaiting requested review from devangrose devangrose is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @pleek91