Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Updates deployment details page to have associated work pools and work queues links #17294

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 26, 2025

Updates deployment details page to have associated work pools and work queues links

Screen.Recording.2025-02-26.at.10.56.20.AM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@devinvillarosa devinvillarosa added the DONT MERGE This PR shouldn't be merged (yet) label Feb 26, 2025
@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 26, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review February 26, 2025 21:17
@devinvillarosa devinvillarosa removed the DONT MERGE This PR shouldn't be merged (yet) label Feb 26, 2025
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

Comment on lines 66 to 68
<Suspense fallback={<LoadingSkeleton numSkeletons={1} />}>
<DeploymentFlowLink flowId={deployment.flow_id} />
</Suspense>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't new code so ignore for this PR. But components that require suspense, should the suspense be inside the component? That way the fallback logic is self contained. Suggestion/question for future us

Copy link
Contributor Author

@devinvillarosa devinvillarosa Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if a component that calls a useSuspenseQuery needs to be wrapped by a Suspense wrapper. Or if they can co-exist on the same level.

I was mostly following this example: https://tanstack.com/router/v1/docs/framework/react/guide/deferred-data-loading#deferred-data-loading-with-external-libraries.

But if Suspense and useSuspenseQuery can live on the same level, then I tink we should have the Suspense be done inside the component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interpreting it as useSuspenseQuery only works for the closest wrapped Suspense.
Screenshot 2025-02-26 at 9 24 53 PM
Screenshot 2025-02-26 at 9 26 52 PM

@devinvillarosa devinvillarosa merged commit 4850083 into main Feb 27, 2025
6 checks passed
@devinvillarosa devinvillarosa deleted the add-flow-details-links branch February 27, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants