-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI v2] feat: Updates deployment details page to have associated work pools and work queues links #17294
Conversation
3b84641
to
e89eb82
Compare
e89eb82
to
b3bcc27
Compare
b3bcc27
to
9c51965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM!
<Suspense fallback={<LoadingSkeleton numSkeletons={1} />}> | ||
<DeploymentFlowLink flowId={deployment.flow_id} /> | ||
</Suspense> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't new code so ignore for this PR. But components that require suspense, should the suspense be inside the component? That way the fallback logic is self contained. Suggestion/question for future us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if a component that calls a useSuspenseQuery
needs to be wrapped by a Suspense
wrapper. Or if they can co-exist on the same level.
I was mostly following this example: https://tanstack.com/router/v1/docs/framework/react/guide/deferred-data-loading#deferred-data-loading-with-external-libraries.
But if Suspense
and useSuspenseQuery
can live on the same level, then I tink we should have the Suspense
be done inside the component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9c51965
to
350c95e
Compare
… pools and work queues links
350c95e
to
241ddab
Compare
Updates deployment details page to have associated work pools and work queues links
Screen.Recording.2025-02-26.at.10.56.20.AM.mov
Checklist
<link to issue>
"mint.json
.