Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isTextInPDF newline comma is really fragile #298

Open
tswfi opened this issue Dec 18, 2024 · 0 comments
Open

isTextInPDF newline comma is really fragile #298

tswfi opened this issue Dec 18, 2024 · 0 comments

Comments

@tswfi
Copy link
Contributor

tswfi commented Dec 18, 2024

while doing PrestaShop/PrestaShop#35356 I stumbled upon this comma issue and while that pr was using older version of utils/file it had the same issue that 1) deleteComma was not properly documented 2) it is really hard to write a test case where whitespace does not matter.

I will open a pr that at least adds some documentation for the next person who is stuck with this but a better solution would be to rename the parameter to "ignoreWhiteSpaceAndNewLines" or something like that and then do that better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant