server: server_data payload sent to clients is incomplete

[extremeheat]

node-minecraft-protocol/src/server/login.js

Lines 199 to 203 in f258c76

	client.write('server_data', {
	previewsChat: options.enableChatPreview,
	// Note: in 1.20.5+ user must send this with `login`
	enforcesSecureChat: options.enforceSecureProfile
	})

doesn't send correct payload for 1.19+

1.19

   packet_server_data:   
      motd?: string
      icon?: string
      previewsChat: bool

1.19.2

   packet_server_data:   
      motd?: string
      icon?: string
      previewsChat: bool
      enforcesSecureChat: bool

1.19.3

   packet_server_data:   
      motd?: string
      icon?: string
      enforcesSecureChat: bool

1.19.4, 1.20, 1.20.2

   packet_server_data:   
      motd: string
      iconBytes?: [
         "buffer",
         {
            "countType": "varint"
         }
      ]
      enforcesSecureChat: bool

1.20.3

   packet_server_data:
      motd: anonymousNbt
      iconBytes?: [
         "buffer",
         {
            "countType": "varint"
         }
      ]
      enforcesSecureChat: bool

1.20.5+

   # MC: ClientboundServerDataPacket
   packet_server_data:
      motd: anonymousNbt
      iconBytes?: ByteArray

Check

• Did icon actually change from string to buffer
• verify motd went optional string -> required string -> nbt (probably caused by JSON chat component to NBT)

Not breaking anything currently though, interestingly

[extremeheat]

1.19 - is a chat component (json) serialized as a string ✅

      var1.writeOptional(this.motd, FriendlyByteBuf::writeComponent);
      var1.writeOptional(this.iconBase64, FriendlyByteBuf::writeUtf);
      var1.writeBoolean(this.previewsChat);

1.19.1/1.19.2 (v760) motd is unchanged ✅

      var1.writeOptional(this.motd, FriendlyByteBuf::writeComponent);
      var1.writeOptional(this.iconBase64, FriendlyByteBuf::writeUtf);
      var1.writeBoolean(this.previewsChat);
      var1.writeBoolean(this.enforcesSecureChat);

1.19.3 motd is unchanged ✅

      var1.writeOptional(this.motd, FriendlyByteBuf::writeComponent);
      var1.writeOptional(this.iconBase64, FriendlyByteBuf::writeUtf);
      var1.writeBoolean(this.enforcesSecureChat);

1.19.4 motd is no longer optional ✅

      var1.writeComponent(this.motd);
      var1.writeOptional(this.iconBytes, FriendlyByteBuf::writeByteArray);
      var1.writeBoolean(this.enforcesSecureChat);

1.20.3 remains a chat component, but these have been changed to be NBT instead of json ✅

      var1.writeComponent(this.motd);
      var1.writeOptional(this.iconBytes, FriendlyByteBuf::writeByteArray);
      var1.writeBoolean(this.enforcesSecureChat);

20.5 same minus last field

      STREAM_CODEC = StreamCodec.composite(
ComponentSerialization.TRUSTED_CONTEXT_FREE_STREAM_CODEC,
 ClientboundServerDataPacket::motd, 
ByteBufCodecs.BYTE_ARRAY.apply(ByteBufCodecs::optional), 
ClientboundServerDataPacket::iconBytes, 
ClientboundServerDataPacket::new);

icon goes from b64 to raw buffer

So mc-data is correct, and nmp is lacking implementation

[extremeheat]

✨✨ Here's an AI-assisted sketch of how you might approach this issue saved by @extremeheat using Copilot Workspace v0.27