Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CMakeLists.txt #6988

Merged
merged 5 commits into from
Feb 22, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/osrm-backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -536,21 +536,13 @@ jobs:
echo "PKG_CONFIG_PATH=${OSRM_INSTALL_DIR}/lib/pkgconfig" >> $GITHUB_ENV
fi
popd
- name: Build example
Copy link
Member

@SiarheiFedartsou SiarheiFedartsou Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DennisOSRM just out of curiosity: do we now consider libosrm as something completely internal? I.e. do not guarantee backward compatibility between releases etc? I had some ideas of various performance optimisations (what I care a lot recently as you may noticed 😄) which could significantly complicate libosrm API, but if it would be completely internal it would ease things a lot 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are no production environments that use libosrm directly. it's one of those features that make sense on the surface of it, but in the end get zero usage. Happy to be convinced otherwise, tho.

if: ${{ matrix.NODE_PACKAGE_TESTS_ONLY != 'ON' }}
run: |
mkdir example/build && pushd example/build
cmake .. -DCMAKE_BUILD_TYPE=${BUILD_TYPE}
make --jobs=${JOBS}
popd
- name: Run all tests
if: ${{ matrix.NODE_PACKAGE_TESTS_ONLY != 'ON' }}
run: |
make -C test/data benchmark

# macOS SIP strips the linker path. Reset this inside the running shell
export LD_LIBRARY_PATH=${{ env.LD_LIBRARY_PATH }}
./example/build/osrm-example test/data/mld/monaco.osrm

# All tests assume to be run from the build directory
pushd ${OSRM_BUILD_DIR}
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ Thumbs.db
#######################
/_build*
/build/
/example/build/
/test/data/monaco.osrm*
/test/data/ch
/test/data/corech
Expand Down
33 changes: 0 additions & 33 deletions docs/libosrm.md

This file was deleted.

34 changes: 0 additions & 34 deletions example/CMakeLists.txt

This file was deleted.

63 changes: 0 additions & 63 deletions example/cmake/FindLibOSRM.cmake

This file was deleted.

1 change: 0 additions & 1 deletion example/cmake/FindTBB.cmake

This file was deleted.

90 changes: 0 additions & 90 deletions example/example.cpp

This file was deleted.

Loading