Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options not working #9

Open
Ed-zo opened this issue Aug 28, 2019 · 1 comment
Open

Options not working #9

Ed-zo opened this issue Aug 28, 2019 · 1 comment

Comments

@Ed-zo
Copy link

Ed-zo commented Aug 28, 2019

There seems to be some kind of problem when I'm trying to install this package using NPM. I found the problem. This method is missing a return keyword.

   _stringifyOptionsArray: function(array) {
         array.map(function(value) { return value === null && '' || value; }).join(';')
  },

This caused that options like sources or destinations were not added to the URL so they did not work. I looked at file on the github and the return is there. First I tought that I deleted it by a mistake and I didn't notice it but after I tried to install my project onto another machine the return was missing again. I don't mind the problem, I fixed it in my sources but if anybody else has problem with options not working have a look in the file src/osrm.js.

@jstrater
Copy link

@Ed-zo I ran into this as well and found that the bug was fixed in 2017 (#5). There just hasn't been an NPM release for quite a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants