Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control to switch workspace type in the workspace side panel (?) #1709

Closed
aeschylus opened this issue Jan 28, 2019 · 6 comments
Closed

Comments

@aeschylus
Copy link
Collaborator

No description provided.

@cbeer
Copy link
Collaborator

cbeer commented Jan 28, 2019

I'm not sure what you mean by workspace type?

@ggeisler
Copy link
Collaborator

ggeisler commented Jan 28, 2019

I think I know what @aeschylus means by workspace type (if he means switching into a different workspace mode that provides alternative windowing behavior, because we expect that no windowing system will provide all the workspace behavior we deem necessary), but I don't think we know yet that we will need workspace types (I certainly hope we can avoid needing them) so it seems premature to say a design is needed to accommodate them. I'd rather we wait to resolve the windowing system decisions before saying workspace types are a requirement that needs to be designed for.

If @aeschylus just means "tile mode" versus "freeform mode", we do have a workspace tools menu affordance for switching into tile mode (switching from tile mode to freeform would just happen if the user moves a window in the workspace, I think):

workspace-window-management-v_4-2

@aeschylus
Copy link
Collaborator Author

aeschylus commented Jan 28, 2019

@ggeisler Yes, this is what I meant. I put this here as a placeholder ticket for discussion to lump in with a bigger ticket when Shaune and I get a chance to bring all this together.

I don't think it's possible to switch into the react-grid-layout kind of system from a freeform system that easily. There are more subtle, global changes that take place in that case. The simple part would be all windows resize and reposition themselves into the grid, but also the scrolling behaviour changes/is added, and any kind of pan or zoom of the workspace, or ability to drag the window outside of the workspace area goes away.

React-grid layout supports dragging windows, but has very specific affordances for how they are placed/contained in the given viewport extent. So I don't think clicking and dragging provides enough information on the user's intent to transition the workspace into freeform mode (which I take to mean "panning, growable extent to place windows in precisely controlled, overlapping positions").

There is also the tiled workspace type à la react mosaic, which fixes the extent in both directions, and seamlessly divides the space while expressing a comparison relationship for easy sharing/reproducibility across device sizes.

@aeschylus aeschylus changed the title Add control to switch workspace type in the workspace side panel Add control to switch workspace type in the workspace side panel (?) Jan 28, 2019
@jvine
Copy link
Collaborator

jvine commented Feb 2, 2019

Related: #1757 (master windowing ticket)

@jvine
Copy link
Collaborator

jvine commented Feb 8, 2019

Created two tickets to address this one:

Create "Select workspace type" dialog and add to workspace menu #1838
Add workspace type-specific options to workspace menu #1839

@ggeisler
Copy link
Collaborator

Superseded by #1838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants