Accessibility: lack of programmatic indication of expand/collapse and selected

[23jaredbarrett]

Throughout the application, there is no programmatic indication of expand/collapse to screen readers.

Places where this occurs:

• Toggle sidebar
• language list dropdown (within "Workspace settings" submenu)
• Select workspace type lacks "aria-selected" attribute
• "Window Views & Thumbnail display" (right next to fullscreen button) lack of aria-selected attribute. Additionally, inactive interface components that are just titles "View" and "Thumbnails" are able to be keyboard focused.
• Sidebar: Index/Annotations lacks aria-selected state.
• Thumbnail panel at the bottom lack aria-selected.

Recommendation: Add aria-expanded to buttons that open submenus, and add aria-selected to elements where state is shown.

Side note: add label accessibility

[mferrarini]

Linking a similar issue reported by @brittnylapierre: #3883

[lutzhelm]

Hi @lhenze, hi @mferrarini, if you can spare the time, would it be possible that you have a look at @fstoe's solution to confirm that the specific issues do no longer occur? A deployed version of PR #3909 can be found here. We did already test and review the changes but I'm not too confident about accessibility issues.

[mferrarini]

@lutzhelm I can try to get to this today or by early next week!