Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT ids #73

Open
niklasp opened this issue Jul 21, 2023 · 2 comments
Open

NFT ids #73

niklasp opened this issue Jul 21, 2023 · 2 comments

Comments

@niklasp
Copy link
Collaborator

niklasp commented Jul 21, 2023

Currently unique NFT ids are generated from the index of the vote in getTxsForVotes. That obviously doesn't work when minting to an already existing collection. We need to think about a unique id for collection NFTs of type u32.

E.g. ${refId}${1-n for rarity index}{voteIndex}

or query nfts.collection to get the number of items and start from numItems + 1
Bildschirmfoto 2023-07-22 um 00 57 15

Ideas?

@gabrieljaegerde
Copy link
Contributor

gabrieljaegerde commented Jul 22, 2023

querying the nfts.collection is not an option as there might be referenda in the queue that assign certain IDs already.

Technically also there could be multiple nft sendouts for the same ref. It's important that we consider that too.

Perhaps we should also think about a way to create new collections for each ref.

@niklasp
Copy link
Collaborator Author

niklasp commented Jul 22, 2023

New collections i will build, the ui is already ready in a way. still i think when we as poc want to start we should mint to a default collection (and maybe encourage others). I imagine having 10s of rewards collections with only 3 different rarities will clutter all NFT marketplaces UIs like crazy and make it even harder for people to follow / organize. I liked how it was done before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants