Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a monorepo for all python-proton-vpn-* packages #47

Open
3 tasks done
ranile opened this issue Apr 28, 2024 · 2 comments
Open
3 tasks done

Consider using a monorepo for all python-proton-vpn-* packages #47

ranile opened this issue Apr 28, 2024 · 2 comments

Comments

@ranile
Copy link

ranile commented Apr 28, 2024

We are happy to answer your questions about the code or discuss technical ideas.

Please complete the following checklist (by adding [x]):

  • I have searched open and closed issues for duplicates
  • This isn't a feature request
  • This is not a report about my app not working as expected

The README states:

Virtual environment

If you didn't do it yet, to be able to pip install Proton VPN components you'll need to set up our internal Python package registry. You can do so running the command below, after replacing {GITLAB_TOKEN} with your personal access token with the scope set to api.

pip config set global.index-url https://__token__:{GITLAB_TOKEN}@{GITLAB_INSTANCE}/api/v4/groups/{GROUP_ID}/-/packages/pypi/simple

This makes the job of using running the app from the source code extremely difficult. Moreover, the README also doesn't mention what GitLab instance to use, which makes me think that the instance being used is https://gitlab.com/, a 3rd party service.

I bring this up as I would like an easy way to build/run the app from source without needing to clone a bunch of other repositories or authenticate with GitLab (which doesn't really make sense since the source is on GitHub and pip can install packages from git)

@elenapan
Copy link

elenapan commented May 7, 2024

According to the ProtonVPN/python-proton-vpn-api-core README:

  • {GITLAB_INSTANCE} should be set to gitlab.protontech.ch
  • {GROUP_ID}should be set to 777

The command then becomes:

pip config set global.index-url https://__token__:{GITLAB_TOKEN}@gitlab.protontech.ch/api/v4/groups/777/-/packages/pypi/simple

However, I get a few errors when trying it:

...
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f8c4c59e0d0>, 'Connection to gitlab.protontech.ch timed out. (connect timeout=15)')': /api/v4/groups/777/-/packages/pypi/simple/proton-vpn-api-core/
INFO: pip is looking at multiple versions of proton-vpn-gtk-app to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement proton-vpn-api-core (from proton-vpn-gtk-app) (from versions: none)
ERROR: No matching distribution found for proton-vpn-api-core

Maybe this repo's README could be updated to include the correct information?

@calexandru2018
Copy link
Contributor

So repo instructions contain are mainly of developers and internal use. Though to note that we currently don't provide support if you build the app from source, mainly because there are many dependencies that need to be in place. I'll take this info to see if we can improve the README.md file, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants